Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-85453: Fix 'time zone' spelling issues across datetime.rst #118449

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

uatach
Copy link
Contributor

@uatach uatach commented Apr 30, 2024

Another pull request based on PR #21447, this one focused on fixing spelling issues on occurrences of 'time zone'.


📚 Documentation preview 📚: https://cpython-previews--118449.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 30, 2024
``astz = dt.astimezone(tz)``, ``astz - astz.utcoffset()`` will have
the same date and time data as ``dt - dt.utcoffset()``.

If you merely want to attach a time zone object *tz* to a datetime *dt* without
If you merely want to attach a :class:`timezone` object *tz* to a datetime *dt* without
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland there are similar issues for occurrences of datetime like this one, but I was not sure if I should include them in the same PR

@uatach uatach changed the title Fix 'time zone' spelling issues across datetime.rst gh-85453: Fix 'time zone' spelling issues across datetime.rst Apr 30, 2024
@pganssle
Copy link
Member

pganssle commented May 1, 2024

I think timezone is also an acceptable spelling, if that's what we've been consistently using, we should probably continue using that.

Alternatively, we could differentiate between datetime.timezone (the class) and the more abstract notion of a "time zone" by including the space for the abstract notion, but I'm more inclined to mark out references to the class with backticks / class references rather than a spelling difference.

@uatach
Copy link
Contributor Author

uatach commented May 1, 2024

I think timezone is also an acceptable spelling, if that's what we've been consistently using, we should probably continue using that.

I'm not sure... the IANA database uses "time zone" and both Wikipedia and The Free Dictionary redirect "timezone" to "time zone"... so maybe "timezone" isn't even valid spelling but people use it anyway?

Alternatively, we could differentiate between datetime.timezone (the class) and the more abstract notion of a "time zone" by including the space for the abstract notion, but I'm more inclined to mark out references to the class with backticks / class references rather than a spelling difference.

Yes, I tried to differentiate all of them (the class and the instances and objects of the class) from the abstract concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants