Skip to content

Commit

Permalink
gh-118433: Temporarily skip test_interrupt_main_subthread in free-t…
Browse files Browse the repository at this point in the history
…hreaded builds (#118485)

Free-threaded builds can intermittently tickle a longstanding bug (24 years!)
in the implementation of `threading.Condition`, leading to flakiness in the
test suite. Fixing the underlying issue will require more discussion, and will
likely apply to most of the concurrency primitives in the `threading` module
that are written in Python. See gh-118433 for more details.
  • Loading branch information
mpage committed May 1, 2024
1 parent 6763bfc commit 8a50544
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Lib/test/test_threading.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"""

import test.support
from test.support import threading_helper, requires_subprocess
from test.support import threading_helper, requires_subprocess, requires_gil_enabled
from test.support import verbose, cpython_only, os_helper
from test.support.import_helper import import_module
from test.support.script_helper import assert_python_ok, assert_python_failure
Expand Down Expand Up @@ -2025,6 +2025,7 @@ def check_interrupt_main_noerror(self, signum):
# Restore original handler
signal.signal(signum, handler)

@requires_gil_enabled("gh-118433: Flaky due to a longstanding bug")
def test_interrupt_main_subthread(self):
# Calling start_new_thread with a function that executes interrupt_main
# should raise KeyboardInterrupt upon completion.
Expand Down

0 comments on commit 8a50544

Please sign in to comment.