-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove notes-to-self #3117
remove notes-to-self #3117
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3117 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 122 122
Lines 18405 18405
Branches 1226 1226
=======================================
Hits 18336 18336
Misses 47 47
Partials 22 22
|
does anybody have any opinions? @A5rocks @njsmith @Zac-HD @oremanj @graingert |
You could git commit them into the wiki https://github.com/python-trio/trio/wiki |
that's a good idea, done: https://github.com/python-trio/trio/wiki/notes-to-self |
Ah I meant to include the history also, eg with filter branch |
Resolved to link to the merged commit back from the wiki in DM |
I think this would only be necessary/useful if we completely wiped the notes-to-self directory from the repository (which I don't think is necessary, while it's 7% of current files it's going to have less impact on the the size of the history since the files have rarely been changed). But I'll add a link to the wiki with the merge commit in case people do want to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add notes-to-self/
to a .gitignore
? This pattern still might be nice to test any new features while adding them.
Done. While I think it's unlikely somebody would create a directory with that exact name to play around with stuff, having people restore the files from history / download them from the wiki seems like a decent use-case. I'll merge this in a bit (and update wiki to refer to the PR) unless anybody has any objections. :) |
notes-to-self can now be viewed at https://github.com/python-trio/trio/wiki/notes-to-self
I don't think these are used by anybody in any way anymore? They mostly just seem to mess with linters/formatters and increase the size of the codebase by 200KB.
If we do want to keep them around for more visibility somewhere, and people actually expect to use and/or update them once in a blue mood, we could consider putting them in a separate repo in the python-trio org?
teamspen suggested making a tag. We could make a dedicated notes-to-self tag, but for now I just reused the
0.27.0
tag.