Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiologic and culsans to Awesome Trio Libraries in the docs #3092

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

x42005e1f
Copy link
Contributor

Hi, I'd like to add aiologic to your list of awesome libraries. My library can be used to communicate with both threads and event loops in those threads, which can also be seen as an alternative approach to Trio/asyncio interoperability. But I'm not sure about which category aiologic is better to be in, so I put it under "Tools and Utilities". No documentation yet, but hopefully someone will find it useful.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (b43383d) to head (1768a9f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3092   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files         124      124           
  Lines       18381    18381           
  Branches     1226     1226           
=======================================
  Hits        18312    18312           
  Misses         47       47           
  Partials       22       22           

@A5rocks
Copy link
Contributor

A5rocks commented Sep 22, 2024

I was looking at your README and it seems pretty nice! I don't think this is a good idea though:

Optional Trio-style checkpoints

If something is optional, that means there are no guarantees. And it's the guarantees that every await will call a checkpoint that make trio easier to use.

@x42005e1f
Copy link
Contributor Author

I agree @A5rocks, it does look weird, but the point is there: if a Trio run loop is running in a thread, then by default every await in that thread will call a checkpoint, otherwise it won't. This behavior can be changed via environment variables: you can even enable checkpoints for synchronous calls at the threading level (and get very nice fairness). It all depends on what the user wants.

@x42005e1f
Copy link
Contributor Author

Now, since the last commit, the above behavior is clarified in my README.

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, though I'm not too sure about the summary. If you think that describes it best then good enough.

@x42005e1f x42005e1f requested a review from A5rocks November 3, 2024 10:50
@x42005e1f x42005e1f changed the title Add aiologic to Awesome Trio Libraries in the docs Add aiologic and culsans to Awesome Trio Libraries in the docs Nov 3, 2024
Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still looks good to me :P

I didn't merge this previously cause I wanted someone else to sanity check. But if nobody does I'll merge this eventually (not that soon though.)

@jakkdl jakkdl enabled auto-merge (squash) December 20, 2024 18:04
@jakkdl jakkdl merged commit 8a3307f into python-trio:main Dec 20, 2024
37 checks passed
@trio-bot
Copy link

trio-bot bot commented Dec 20, 2024

Hey @x42005e1f, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants