Improve REPL KI #3030
Draft
Improve REPL KI #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
==========================================
- Coverage 99.63% 99.59% -0.04%
==========================================
Files 120 120
Lines 17830 17852 +22
Branches 3204 3207 +3
==========================================
+ Hits 17765 17780 +15
- Misses 46 52 +6
- Partials 19 20 +1
|
|
Could we spawn the REPL as another process and send it a signal? (simulate ctrl+c) I think we could first send it some data over stdin to get into specific scenarios. |
|
The newline is sent to the terminal I think, rather than any specific process. Potentially we could avoid the ioctl weirdness by allowing a small amount of user discomfort in needing to press enter after Ctrl+C. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has a draft method to fix #3007. I have 0 ideas on how to test this thing: not only does it use the
raw_inputthat gets patched for testing, but the way it injects a newline is basically impossible for a test runner to pass in. Also, it feels fragile somehow to dip in and out of the trio loop patching the signal handler and peeking forKeyboardInterrupt.