implement StapledMemoryChannel #1784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partially addresses python-trio#719
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 114 114
Lines 14453 14486 +33
Branches 1105 1106 +1
=======================================
+ Hits 14401 14434 +33
Misses 37 37
Partials 15 15
|
|
It looks like codecov was down when you submitted that pull request. Closing/reopening |
|
@belm0 Codecov now complains about |
|
3.9.0-rc2 stalled when installing dependencies, closing/reopening... |
|
@njsmith please take a look I started with StapledMemoryChannel rather than StapledChannel, since my use case is needing the nowait methods. Not sure whether it's worth making a MemoryChannel abc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #719