Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize the compressible sdc solver #331

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

zingale
Copy link
Collaborator

@zingale zingale commented Jan 24, 2025

we don't need to recompute the old advective term every step we also never need to compute the advective term at m = 0 after the first time

we don't need to recompute the old advective term every step
we also never need to compute the advective term at m = 0
after the first time
@zingale
Copy link
Collaborator Author

zingale commented Jan 24, 2025

This is now 2x faster when running acoustic_pulse on a 128x128 grid: 61.1 s on main vs. 30.5 s on this PR. The results agree perfectly.

@zingale zingale merged commit 229f64a into python-hydro:main Jan 24, 2025
13 checks passed
@zingale zingale deleted the optimize_sdc_solver branch January 24, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant