Fix pybabel update --init-missing not creating parent directory
#1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
requested changes
Nov 5, 2024
| @@ -626,8 +626,8 @@ def finalize_options(self): | |||
| self.output_file = os.path.join(self.output_dir, self.locale, | |||
| 'LC_MESSAGES', f"{self.domain}.po") | |||
|
|
|||
| if not os.path.exists(os.path.dirname(self.output_file)): | |||
| os.makedirs(os.path.dirname(self.output_file)) | |||
| os.makedirs(os.path.dirname(self.output_file),exist_ok=True) | |||
There was a problem hiding this comment.
Suggested change
| os.makedirs(os.path.dirname(self.output_file),exist_ok=True) | |
| os.makedirs(os.path.dirname(self.output_file), exist_ok=True) |
Comment on lines
+783
to
793
| tmpInitCatalog = InitCatalog(self.distribution) | ||
| tmpInitCatalog.output_dir = None | ||
| tmpInitCatalog.output_file = filename | ||
| tmpInitCatalog.input_file = self.input_file | ||
| tmpInitCatalog.locale = self.locale | ||
| tmpInitCatalog.domain = self.domain | ||
| tmpInitCatalog.no_wrap = self.no_wrap | ||
| tmpInitCatalog.width = self.width | ||
| tmpInitCatalog.finalize_options() | ||
| tmpInitCatalog.run() | ||
|
|
There was a problem hiding this comment.
Variable names should be in snake_case, not camelCase.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1142 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 27 27
Lines 4623 4624 +1
=======================================
+ Hits 4220 4221 +1
Misses 403 403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the redundant init logic in
UpdateCatalog.run()with a temporaryInitCataloginstance to ensure the parent directory of the output file will be created. (close #1139)