Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package property to FixtureRequest #12853

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add package property to FixtureRequest #12853

wants to merge 3 commits into from

Conversation

apvd
Copy link

@apvd apvd commented Oct 4, 2024

@apvd apvd changed the title Fixture package scope Add package property to FeatureRequest Oct 4, 2024
@apvd apvd marked this pull request as draft October 4, 2024 19:49
nicoddemus
nicoddemus requested changes Oct 5, 2024
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start!

Requests:

  • Add a new feature changelog entry?
  • Add yourself to AUTHORS (optional)
  • Add an specific test for this feature: a request accessing the new property explicitly, ensuring it is the object we expect.

@webknjaz webknjaz changed the title Add package property to FeatureRequest Add package property to FixtureRequest Oct 23, 2024
@webknjaz
Copy link
Member

@apvd I've fixed a typo in the PR title. Please note that you have a list of requested changes from another maintainer above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apvd @webknjaz @nicoddemus