display alerts from today #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blenzi
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Thanks a lot for this addition @MateoLostanlen. Just a minor suggestion about the comparisons.
I agree that a separate functionality and ideally another dashboard that allows retrieving the images and information about older alerts (by date, site, etc) is required. At very least this PR must pass to allow it on the API side: pyronear/pyro-api#277.
blenzi
approved these changes
Oct 17, 2023
MateoLostanlen
added a commit
that referenced
this pull request
Oct 25, 2023
MateoLostanlen
added a commit
that referenced
this pull request
Oct 30, 2023
* revert change from #111 * create filtering function * filter live event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by several users, I propose to display only the current day's alerts, as the previous days are useless for firefighters.
There are two options for accessing the history:
A dashboard page with history stats and access to images.
The ability to specify a date range for alerts to be displayed.
In my opinion, the dashboard is the best option, let's just do it in another PR.
The PR is relatively simple: I filter the days that are not equal to today.
I fixed a small error with filtered_df at the same time