Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose long double in _ffi (which is _rawffi.alt) and ctypes #4804

Closed
wants to merge 3 commits into from

Conversation

gitlab-importer
Copy link

In GitLab by @mattip on Oct 4, 2020, 00:26

Support longdouble in _rawffi.alt, which will make it available to ctypes

@gitlab-importer
Copy link
Author

In GitLab by @arigo on Oct 4, 2020, 08:50

Class LongDoubleArg still contains a raise NotImplementedError that looks like it can be reached at runtime.

@gitlab-importer
Copy link
Author

In GitLab by @mattip on Oct 4, 2020, 09:30

How can I write a test that would hit that code path? Wouldn't we need a space.w_longdouble?

@gitlab-importer
Copy link
Author

In GitLab by @mattip on Oct 4, 2020, 09:34

added 1 commit

  • 65877468 - add assert, but why is it needed?

Compare with previous version

@gitlab-importer
Copy link
Author

In GitLab by @mattip on Oct 4, 2020, 23:33

added 1 commit

  • ab304eea - fix check

Compare with previous version

@gitlab-importer
Copy link
Author

In GitLab by @mattip on Oct 7, 2020, 11:23

Translations and own tests are passing for windows and linux 64

@gitlab-importer
Copy link
Author

In GitLab by @mattip on Oct 7, 2020, 13:20

.. and macos too (clang). I think that class can only be reached if there is a space.w_longdouble

@gitlab-importer
Copy link
Author

In GitLab by @arigo on Oct 7, 2020, 17:57

OK, but then why is there a class LongDoubleArg at all, if the TYPE can never be rffi.LONGDOUBLE? That is unreachable and untested code, and so it shouldn't be added at all, no?

@mattip
Copy link
Member

mattip commented Aug 28, 2024

Closing as "not needed"

@mattip mattip closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants