Change to a boolean field

pypi · Dec 10, 2024 · 60de6e8 · 60de6e8
1 parent 60f4a01
commit 60de6e8
Show file tree

Hide file tree

Showing 8 changed files with 113 additions and 108 deletions.
diff --git a/tests/common/db/packaging.py b/tests/common/db/packaging.py
@@ -100,9 +100,6 @@ class Meta:
 
     uploader = factory.SubFactory(UserFactory)
     description = factory.SubFactory(DescriptionFactory)
-    published = factory.Faker(
-        "date_time_between_dates", datetime_start=datetime.datetime(2008, 1, 1)
-    )
 
 
 class FileFactory(WarehouseFactory):

diff --git a/tests/unit/forklift/test_legacy.py b/tests/unit/forklift/test_legacy.py
@@ -3613,6 +3613,7 @@ def test_upload_succeeds_creates_release(
                 else None
             ),
             "uploaded_via_trusted_publisher": not test_with_user,
+            "published": True,
         }
 
         fileadd_event = {

diff --git a/tests/unit/packaging/test_views.py b/tests/unit/packaging/test_views.py
@@ -9,7 +9,6 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-from datetime import datetime
 
 import pretend
 import pytest
@@ -326,12 +325,7 @@ def test_long_singleline_license(self, db_request):
 
     def test_created_with_published(self, db_request):
         release = ReleaseFactory.create()
-        assert release.published > datetime(year=2008, month=1, day=1)
-
-    def test_without_published_date(self, db_request):
-        release = ReleaseFactory.create(published=None)
-        db_request.db.flush()
-        assert release.published is None
+        assert release.published is True
 
 
 class TestReportMalwareButton:

diff --git a/warehouse/forklift/legacy.py b/warehouse/forklift/legacy.py
@@ -19,7 +19,6 @@
 import zipfile
 
 from cgi import FieldStorage
-from datetime import datetime
 
 import packaging.requirements
 import packaging.specifiers
@@ -903,7 +902,6 @@ def file_upload(request):
             },
             uploader=request.user if request.user else None,
             uploaded_via=request.user_agent,
-            published=datetime.now(),
         )
         request.db.add(release)
         is_new_release = True
@@ -934,6 +932,7 @@ def file_upload(request):
                     else None
                 ),
                 "uploaded_via_trusted_publisher": bool(request.oidc_publisher),
+                "published": True,
             },
         )