Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2728: Activating venv create unwanted console output #2748

Merged
merged 4 commits into from
Sep 7, 2024

Conversation

ShootGan
Copy link
Contributor

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

Fix problem related with #2728

  • [x ] ran the linter to address style issues (tox -e fix)
  • [x ] wrote descriptive pull request text
  • [x ] ensured there are test(s) validating the fix
  • [x ] added news fragment in docs/changelog folder
  • [x ] updated/extended the documentation

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test please

@ShootGan
Copy link
Contributor Author

@gaborbernat do you mean I should write a test for this change?

@gaborbernat
Copy link
Contributor

Yes.

@ShootGan
Copy link
Contributor Author

So I need help with testing. I can't figure out how tests works in this project.

@gaborbernat gaborbernat merged commit 61e774f into pypa:main Sep 7, 2024
43 of 45 checks passed
ldetmer referenced this pull request in googleapis/sdk-platform-java Sep 9, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [virtualenv](https://redirect.github.com/pypa/virtualenv) |
`==20.26.3` -> `==20.26.4` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/virtualenv/20.26.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/virtualenv/20.26.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/virtualenv/20.26.3/20.26.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/virtualenv/20.26.3/20.26.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pypa/virtualenv (virtualenv)</summary>

###
[`v20.26.4`](https://redirect.github.com/pypa/virtualenv/releases/tag/20.26.4)

[Compare
Source](https://redirect.github.com/pypa/virtualenv/compare/20.26.3...20.26.4)

<!-- Release notes generated using configuration in .github/release.yml
at 20.26.4 -->

#### What's Changed

- release 20.26.3 by
[@&#8203;gaborbernat](https://redirect.github.com/gaborbernat) in
[https://github.com/pypa/virtualenv/pull/2742](https://redirect.github.com/pypa/virtualenv/pull/2742)
- Fix whitespace around backticks in changelog by
[@&#8203;edmorley](https://redirect.github.com/edmorley) in
[https://github.com/pypa/virtualenv/pull/2751](https://redirect.github.com/pypa/virtualenv/pull/2751)
- Test latest Python 3.13 by
[@&#8203;hugovk](https://redirect.github.com/hugovk) in
[https://github.com/pypa/virtualenv/pull/2752](https://redirect.github.com/pypa/virtualenv/pull/2752)
- Fix typo in Nushell activation script by
[@&#8203;edmorley](https://redirect.github.com/edmorley) in
[https://github.com/pypa/virtualenv/pull/2754](https://redirect.github.com/pypa/virtualenv/pull/2754)
- GitHub Actions: Replace deprecated macos-12 with macos-13 by
[@&#8203;hugovk](https://redirect.github.com/hugovk) in
[https://github.com/pypa/virtualenv/pull/2756](https://redirect.github.com/pypa/virtualenv/pull/2756)
- Fix
[#&#8203;2728](https://redirect.github.com/pypa/virtualenv/issues/2728):
Activating venv create unwanted console output by
[@&#8203;ShootGan](https://redirect.github.com/ShootGan) in
[https://github.com/pypa/virtualenv/pull/2748](https://redirect.github.com/pypa/virtualenv/pull/2748)
- Upgrade bundled wheels by
[@&#8203;gaborbernat](https://redirect.github.com/gaborbernat) in
[https://github.com/pypa/virtualenv/pull/2760](https://redirect.github.com/pypa/virtualenv/pull/2760)

#### New Contributors

- [@&#8203;ShootGan](https://redirect.github.com/ShootGan) made their
first contribution in
[https://github.com/pypa/virtualenv/pull/2748](https://redirect.github.com/pypa/virtualenv/pull/2748)

**Full Changelog**:
pypa/virtualenv@20.26.3...20.26.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
ldetmer referenced this pull request in googleapis/sdk-platform-java Sep 17, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [virtualenv](https://redirect.github.com/pypa/virtualenv) |
`==20.26.3` -> `==20.26.4` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/virtualenv/20.26.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/virtualenv/20.26.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/virtualenv/20.26.3/20.26.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/virtualenv/20.26.3/20.26.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pypa/virtualenv (virtualenv)</summary>

###
[`v20.26.4`](https://redirect.github.com/pypa/virtualenv/releases/tag/20.26.4)

[Compare
Source](https://redirect.github.com/pypa/virtualenv/compare/20.26.3...20.26.4)

<!-- Release notes generated using configuration in .github/release.yml
at 20.26.4 -->

#### What's Changed

- release 20.26.3 by
[@&#8203;gaborbernat](https://redirect.github.com/gaborbernat) in
[https://github.com/pypa/virtualenv/pull/2742](https://redirect.github.com/pypa/virtualenv/pull/2742)
- Fix whitespace around backticks in changelog by
[@&#8203;edmorley](https://redirect.github.com/edmorley) in
[https://github.com/pypa/virtualenv/pull/2751](https://redirect.github.com/pypa/virtualenv/pull/2751)
- Test latest Python 3.13 by
[@&#8203;hugovk](https://redirect.github.com/hugovk) in
[https://github.com/pypa/virtualenv/pull/2752](https://redirect.github.com/pypa/virtualenv/pull/2752)
- Fix typo in Nushell activation script by
[@&#8203;edmorley](https://redirect.github.com/edmorley) in
[https://github.com/pypa/virtualenv/pull/2754](https://redirect.github.com/pypa/virtualenv/pull/2754)
- GitHub Actions: Replace deprecated macos-12 with macos-13 by
[@&#8203;hugovk](https://redirect.github.com/hugovk) in
[https://github.com/pypa/virtualenv/pull/2756](https://redirect.github.com/pypa/virtualenv/pull/2756)
- Fix
[#&#8203;2728](https://redirect.github.com/pypa/virtualenv/issues/2728):
Activating venv create unwanted console output by
[@&#8203;ShootGan](https://redirect.github.com/ShootGan) in
[https://github.com/pypa/virtualenv/pull/2748](https://redirect.github.com/pypa/virtualenv/pull/2748)
- Upgrade bundled wheels by
[@&#8203;gaborbernat](https://redirect.github.com/gaborbernat) in
[https://github.com/pypa/virtualenv/pull/2760](https://redirect.github.com/pypa/virtualenv/pull/2760)

#### New Contributors

- [@&#8203;ShootGan](https://redirect.github.com/ShootGan) made their
first contribution in
[https://github.com/pypa/virtualenv/pull/2748](https://redirect.github.com/pypa/virtualenv/pull/2748)

**Full Changelog**:
pypa/virtualenv@20.26.3...20.26.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants