Add front-end display logs #1530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, logs can only be viewed through ssh. After front-end logs are displayed, you can view them more easily.
pymumu
reviewed
Oct 28, 2023
|
|
||
| [ -s ${log_file} ] || { | ||
| [ -d "$log_dir" ] || { | ||
| make_dir "$log_dir" || return 1 |
There was a problem hiding this comment.
这里为什么要在启动程序前创建目录？
smartdns程序会自动创建目录，这里是不是可以不用？
There was a problem hiding this comment.
去掉创建目录代码修改为其他目录，测试了一下，貌似前端可以读取日志。。。！
明天再测试一下，如果没问题就去掉创建目录代码！
There was a problem hiding this comment.
看了一下源码并经测试，最终确定，无论设置何路径，软件会自动按照设置的路径生成日志，因此可以不需要启动前创建目录，此pr关闭。不过luci添加了前端显示日志的pr，请大佬合并！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, logs can only be viewed through ssh. After front-end logs are displayed, you can view them more easily.