Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codecov action version. #1091

Closed

Conversation

BenediktBurger
Copy link
Member

Maybe version 4 is a fix for #1090

@driftregion
Copy link
Contributor

Here is a purportedly successful bump in codecov version from 3 to 4:
https://github.com/Open-Attestation/document-store/pull/170/files

(linked from codecov/codecov-action#1292)

@BenediktBurger
Copy link
Member Author

Here is a purportedly successful bump in codecov version from 3 to 4: https://github.com/Open-Attestation/document-store/pull/170/files

(linked from codecov/codecov-action#1292)

Thanks for making me aware of that. Unfortunately, they have another issue with a workflow calling another one, but both are in the main repo.

Our problem is, that work flows in forks cannot access the secret token.

@driftregion
Copy link
Contributor

It seems the established solution is to use pull_request_target. Example: hyperledger/firefly-tezosconnect#20

See also:
codecov/codecov-action#29

This solution seems to be unviable if there is potential for abuse of the codecov token or other secrets. I haven't yet found anything on whether or not it's possible to isolate secrets to a particular workflow.

@BenediktBurger
Copy link
Member Author

As this PR is from a fork, the upload will fail, such that it cannot be tested.

@BenediktBurger BenediktBurger deleted the codecov-update branch April 29, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants