Rethink2 to pymc v5 #234
Open
Rethink2 to pymc v5 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
pre-commit is passing locally. Not sure what's causing the issue. |
|
Amazing effort! |
|
The pre-commit looks to be a version problem maybe. |
Closed
Merged
|
@yahrMason Can you rebase? should fix pre-commit issues. |
|
@twiecki ah yep, that solved it. Thanks for that. |
|
I think @cluhmann had started on a conversion as well, so maybe he can take a look. |
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rethinking_2 Conversion to PyMC v5+
I am working on updating the Rethinking_2 notebooks to the current version of PyMC + Pytensor. The changes I am making are:
idataas opposed totrace)coordsto manage model dimensionsI made an initial pass through the notebooks and changed all aesara/theano refs to pytensor, and changed the names of all inference data objects to the standard
idataconvention. Now I need to go through the notebooks and execute them and make sure that they run properly. The following list tracks my progress. Anyone feel free to clone my branch and make edits/updates.To Do:
coordsandidata_kwargs={"log_likelihood": True}