Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/scss bulma #10

Open
wants to merge 4 commits into
base: static
Choose a base branch
from
Open

Feature/scss bulma #10

wants to merge 4 commits into from

Conversation

jkomyno
Copy link

@jkomyno jkomyno commented Oct 7, 2018

  • Added SCSS support
  • Added Bulma framework as a responsive, mobile-first and configurable CSS framework
  • Defined palette with the original website colours

@sahitpj, no screenshot attached yet since this PR acts as a code and configuration basement for all future PRs, which will involve design features.

Copy link

@sahitpj sahitpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing that will do, assuming no bugs then right?

@jkomyno
Copy link
Author

jkomyno commented Oct 8, 2018

Of course. There was a trivial path bug that I already had solved in this commit. I could set up a travis build file so that the package.json's scripts are runned and checked automatically, since at the moment this is a manual process.

@sahitpj
Copy link

sahitpj commented Oct 9, 2018

yupp I think a Travis CI would be really helpful 😄 @jkomyno

@jkomyno
Copy link
Author

jkomyno commented Oct 9, 2018

@sahitpj Do you want me to add support to Travis in this PR or in the next one?

@sahitpj
Copy link

sahitpj commented Oct 18, 2018

hey @jkomyno do add it on this another PR, will merge that first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants