Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use np.real and np.imag when possible #9368

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Aug 15, 2024

This reduces NamedArray's minimum requirements for a duckarray.

For example pd.Index doesn't have .real and .imag (or __array_function__/__array_namespace__ unfortunately, a problem for another PR...).

xref: #9314

@Illviljan Illviljan changed the title Namedarray np2 imag real Use np.real and np.imag when possible Aug 15, 2024
@Illviljan Illviljan added the topic-NamedArray Lightweight version of Variable label Aug 15, 2024
@Illviljan Illviljan marked this pull request as ready for review August 15, 2024 21:05
@Illviljan
Copy link
Contributor Author

================================== FAILURES ===================================
________________________ xarray/tests/test_backends.py ________________________
[gw0] win32 -- Python 3.12.5 C:\Users\runneradmin\micromamba\envs\xarray-tests\python.exe
worker 'gw0' crashed while running 'xarray/tests/test_backends.py::TestNetCDF4ViaDaskData::test_roundtrip_coordinates'

flaky?

@TomNicholas
Copy link
Member

flaky?

Everything "dask roundtrip" seems to be somewhat flaky in my experience.

@max-sixty
Copy link
Collaborator

(I would be +1 on xfailing anything like that, not as good as fixing but better than letting it break some reasonably high % of CI...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-NamedArray Lightweight version of Variable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants