-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use np.real and np.imag when possible #9368
Open
Illviljan
wants to merge
8
commits into
pydata:main
Choose a base branch
from
Illviljan:namedarray_np2_imag_real_
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illviljan
changed the title
Namedarray np2 imag real
Use np.real and np.imag when possible
Aug 15, 2024
for more information, see https://pre-commit.ci
max-sixty
reviewed
Aug 15, 2024
…jan/xarray into namedarray_np2_imag_real_
flaky? |
Everything "dask roundtrip" seems to be somewhat flaky in my experience. |
(I would be +1 on xfailing anything like that, not as good as fixing but better than letting it break some reasonably high % of CI...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces NamedArray's minimum requirements for a
duckarray
.For example
pd.Index
doesn't have.real
and.imag
(or__array_function__
/__array_namespace__
unfortunately, a problem for another PR...).xref: #9314