Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress 'rtd-footer-container' if not being built on ReadTheDocs #2013

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DocOtak
Copy link

@DocOtak DocOtak commented Oct 11, 2024

This PR attempts to fix #1794 and possibly #1238 by not including the rtd-footer-container div if the site is not being built on ReadTheDocs.

This uses the same {% if READTHEDOCS %} as the ethical ads html.

@DocOtak
Copy link
Author

DocOtak commented Oct 12, 2024

Two alternatives to this I think are either to give the rtd-footer-container a min-height of 1rem. Or set the bottom margin to 0. The negative top and bottom combined with the zero height of this div when there is no content has the effect of pulling the div 1rem bellow its parent's bottom.

edit: I think doing the min-height option might be more correct for what I think is intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of a vertical scroll bar as a result of rtd-footer-container on none RTD hosted sites
1 participant