Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when Pydantic dataclasses are used on models #9388

Merged
merged 3 commits into from May 15, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented May 3, 2024

Fixes #9383

pydantic/dataclasses.py Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented May 6, 2024

CodSpeed Performance Report

Merging #9388 will not alter performance

Comparing Viicos:dataclass-from-model (531f3c2) with main (8facabb)

Summary

✅ 13 untouched benchmarks

@Viicos
Copy link
Contributor Author

Viicos commented May 13, 2024

Waiting for directions regarding the test_public_internal test failure, as is_model_class isn't reexported.

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Viicos,

Great work here. I've made one suggestion re fixing the test failures. You can pull in the changes from main to fix the typing-extensions tests as well :).

@sydney-runkle sydney-runkle merged commit af7c6d5 into pydantic:main May 15, 2024
52 checks passed
@Viicos Viicos deleted the dataclass-from-model branch May 16, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants