-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt ghi_clear variable name for clearsky GHI #2306
base: main
Are you sure you want to change the base?
Conversation
Change to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty lost here:(
Kinda my fault for not documenting what I thought was obvious, sorry 😬
You have to rename the variables in the signature, see suggestions.
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: Echedey Luis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore the comment below, PR nailed, @RDaxini ! Well done using that random, undocumented decorator.
Co-authored-by: Echedey Luis <[email protected]>
Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Also related: #1253, #2274