Make dni_extra a required parameter for ghi_from_poa_driesse_2023 (…

…#2331) * make dni_extra a required parameter * update whatsnew * Update docs/sphinx/source/whatsnew/v0.11.2.rst Co-authored-by: Echedey Luis <[email protected]> --------- Co-authored-by: Echedey Luis <[email protected]>
pvlib · Dec 12, 2024 · c12a477 · c12a477
1 parent 042af42
commit c12a477
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/docs/sphinx/source/whatsnew/v0.11.2.rst b/docs/sphinx/source/whatsnew/v0.11.2.rst
@@ -22,6 +22,8 @@ Bug Fixes
   (:issue:`1338`, :pull:`2227`)
 * Handle DST transitions that happen at midnight in :py:func:`pvlib.solarposition.hour_angle`
   (:issue:`2132` :pull:`2133`)
+* Changed ``dni_extra`` to a required parameter in :py:func:`pvlib.irradiance.ghi_from_poa_driesse_2023`
+  (:issue:`2279` :pull:`2331`)
 
 Bug fixes
 ~~~~~~~~~
@@ -85,3 +87,4 @@ Contributors
 * Echedey Luis (:ghuser:`echedey-ls`)
 * Kevin Anderson (:ghuser:`kandersolar`)
 * Scott Nelson (:ghuser:`scttnlsn`)
+* Ioannis Sifnaios (:ghuser:`IoannisSifnaios`)
diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py
@@ -1528,7 +1528,7 @@ def poa_error(ghi):
 def ghi_from_poa_driesse_2023(surface_tilt, surface_azimuth,
                               solar_zenith, solar_azimuth,
                               poa_global,
-                              dni_extra=None, airmass=None, albedo=0.25,
+                              dni_extra, airmass=None, albedo=0.25,
                               xtol=0.01,
                               full_output=False):
     '''
@@ -1549,7 +1549,7 @@ def ghi_from_poa_driesse_2023(surface_tilt, surface_azimuth,
         Solar azimuth angle. [degree]
     poa_global : numeric
         Plane-of-array global irradiance, aka global tilted irradiance. [Wm⁻²]
-    dni_extra : numeric, optional
+    dni_extra : numeric
         Extraterrestrial direct normal irradiance. [Wm⁻²]
     airmass : numeric, optional
         Relative airmass (not adjusted for pressure). [unitless]