R10k non-sidecar deployment fixes #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
justicel
changed the title
|
Hey @justicel - could you please try following the pattern in this PR: https://github.com/puppetlabs/puppetserver-helm-chart/pull/185/files We need the CHANGELOG updated and some other stuff without which we can't release your updates. Thank you for your contribution! 🥇 |
|
@justicel Ping 🙂 |
|
@justicel Could you please resolve the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an r10k issue when trying to deploy not as a sidecar container. The Values variable name is lowercase, causing compile issues.