Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScheduledSingleThreadExecutor.awaitTermination exception for nano time calculation error #319

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MapleMaster
Copy link

DESCRIPTION
ScheduledSingleThreadExecutor.awaitTermination crashes for Thread.join() second parameter nanos out of range, which is calculated wrong in awaitTermination ().
worker.join(millis, (int) (nanos - millis));

By the way, nobody ever calls this function? Does it mean we no need to await for a fiber ?

@MapleMaster
Copy link
Author

It seems Project Loom is very active recently, how about it compare to Quasar? And what's the future plan for Loom and Quasar development?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant