Adds vocabulary column to subject table #3386
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mzelesky and I reviewed the search results of this PR. It seems to be a little bit more complicated and we should discuss this in the Orangelight meeting on 2/9/2023. |
christinach
force-pushed
the
authority-vocab-updates-v2
branch
from
1394f60
to
d0f0ab5
Compare
In the OL/Bibdata meeting we discussed that we need to support browselists with the additional subject and vocabulary searches that we've added in the recent years.
|
update multiple genre vocab Update the browse_facet task to check for subject facet update browselists load_facet to look for subject facet Include fixtures Updates subjects.sorted Co-authored-by: Nikitas Tampakis <[email protected]>
christinach
force-pushed
the
authority-vocab-updates-v2
branch
from
d0f0ab5
to
f2235f4
Compare
|
@christinach when I update this PR put back the .sorted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1982
closes #1376
update multiple genre vocab
Update the browse_facet task to check for subject facet update browselists load_facet to look for subject facet Include fixtures
Updates subjects.sorted