Follow redirects on pull endpoint #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -163,6 +163,17 @@ func (dl *Download) Execute() error { | |||
| return ErrDownloadFailed | |||
| } | |||
| defer res.Body.Close() | |||
|
|
|||
| //If the http code is a redirect get the location and set the url to that | |||
There was a problem hiding this comment.
Please note the security implications of this (noted at the start):
wings/router/downloader/downloader.go
Lines 25 to 33 in 3b0ecca
There was a problem hiding this comment.
Since it uses recursion and the execute function first checks if the URL is in the local network it should throw an error if its in the local network.
Boy132
reviewed
Mar 3, 2023
| if res.StatusCode == http.StatusMovedPermanently || res.StatusCode == http.StatusFound { | ||
| redirect, redirectError := url.Parse(res.Header.Get("Location")) | ||
| if redirectError != nil { | ||
| return errors.New("downloader: redirect specified without loication") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds following pull requests on the pull endpoint. I don't have that much experience in Go so someone should probably check to make sure I didn't break anything.