Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass response (self) to ConnectionError constructor #6270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ErikBjare
Copy link

As far as I can tell, this is the only internal construction of ConnectionError that doesn't include request or response.

Part of improving typing for exceptions in requests: python/typeshed#8989

As far as I can tell, this is the only internal construction of `ConnectionError` that doesn't include `request` or `response`.

Part of improving typing for exceptions in requests: python/typeshed#8989
Copy link

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not associated with requests in any way, but looks good to me and is a desirable change. (I also came here from python/typeshed#8989)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants