some improvements to the last commit

git-svn-id: https://olap4j.svn.sourceforge.net/svnroot/olap4j/trunk@488 c6a108a4-781c-0410-a6c6-c2d559e19af0
ps3331333 · Jan 18, 2012 · c75477a · c75477a
1 parent 33206a9
commit c75477a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/org/olap4j/driver/xmla/XmlaOlap4jCatalog.java b/src/org/olap4j/driver/xmla/XmlaOlap4jCatalog.java
@@ -154,7 +154,7 @@ public String getName() {
  return name;
  }
 
- public List<String> getAvailableRoles() {
+ protected List<String> getAvailableRoles() {
  return roles;
  }
 

diff --git a/src/org/olap4j/driver/xmla/XmlaOlap4jConnection.java b/src/org/olap4j/driver/xmla/XmlaOlap4jConnection.java
@@ -126,7 +126,7 @@ abstract class XmlaOlap4jConnection implements OlapConnection {
  * calls as part of &lt;PropertyList/&gt;.<br />
  * Can be passed to connection via connection string properties.
  */
- private Properties databaseProperties;
+ private final Properties databaseProperties;
 
  private boolean autoCommit;
  private boolean readOnly;
@@ -740,7 +740,7 @@ public String getRoleName() {
  }
 
  public List<String> getAvailableRoleNames() {
- Set<String> roleNames = new HashSet<String>();
+ Set<String> roleNames = new LinkedHashSet<String>();
  try {
  for (Catalog catalog : getOlapCatalogs()) {
  List<String> catalogRoles =