Skip to content

Commit

Permalink
fix checkFile errors, add unit tests for previously commited bug fixe…
Browse files Browse the repository at this point in the history
…s: crossjoin sort, except and compound filter

git-svn-id: https://olap4j.svn.sourceforge.net/svnroot/olap4j/trunk@356 c6a108a4-781c-0410-a6c6-c2d559e19af0
  • Loading branch information
pstoellberger committed Oct 8, 2010
1 parent 3d67870 commit b8cb21d
Show file tree
Hide file tree
Showing 3 changed files with 342 additions and 11 deletions.
29 changes: 19 additions & 10 deletions src/org/olap4j/mdx/CallNode.java
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public CallNode deepCopy() {
this.syntax,
MdxUtil.deepCopyList(argList));
}

@Override
public int hashCode() {
final int prime = 31;
Expand All @@ -201,28 +201,37 @@ public int hashCode() {

@Override
public boolean equals(Object obj) {
if (this == obj)
if (this == obj) {
return true;
if (obj == null)
}
if (obj == null) {
return false;
if (getClass() != obj.getClass())
}
if (getClass() != obj.getClass()) {
return false;
}
CallNode other = (CallNode) obj;
if (argList == null) {
if (other.argList != null)
if (other.argList != null) {
return false;
} else if (!argList.equals(other.argList))
}
} else if (!argList.equals(other.argList)) {
return false;
}
if (name == null) {
if (other.name != null)
if (other.name != null) {
return false;
} else if (!name.equals(other.name))
}
} else if (!name.equals(other.name)) {
return false;
}
if (syntax == null) {
if (other.syntax != null)
if (other.syntax != null) {
return false;
} else if (!syntax.equals(other.syntax))
}
} else if (!syntax.equals(other.syntax)) {
return false;
}
return true;
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/org/olap4j/query/Olap4jNodeConverter.java
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ private static void generateUnionsRecursively(
if (!found) {
// add the first selection of the dimension
if (dimension.getInclusions().size() > 0) {
sels.add(toOlap4j(dimension.getInclusions().get(0)));
sels.add(toOlap4j(
dimension.getInclusions().get(0)));
}
}
}
Expand Down
Loading

0 comments on commit b8cb21d

Please sign in to comment.