Skip to content

Commit

Permalink
Forgot to commit these in last commit.
Browse files Browse the repository at this point in the history
git-svn-id: https://olap4j.svn.sourceforge.net/svnroot/olap4j/trunk@120 c6a108a4-781c-0410-a6c6-c2d559e19af0
  • Loading branch information
lucboudreau committed Oct 21, 2008
1 parent 19f9d9d commit 7f766f2
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
18 changes: 14 additions & 4 deletions src/org/olap4j/driver/xmla/XmlaOlap4jConnection.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@
import java.util.Map.*;
import java.util.regex.*;

import javax.xml.transform.*;
import javax.xml.transform.dom.*;
import javax.xml.transform.stream.*;

/**
* Implementation of {@link org.olap4j.OlapConnection}
* for XML/A providers.
Expand Down Expand Up @@ -658,11 +662,17 @@ Element xxx(String request) throws OlapException {
</SOAP-ENV:Fault>
*/
// TODO: log doc to logfile
final Element faultstring = findChild(fault, null, "faultstring");
String message = faultstring.getTextContent();
StringWriter writer = new StringWriter();
writer.append("The SOAP service end-point returned an error message.");
try {
Transformer transformer = TransformerFactory.newInstance().newTransformer();
transformer.transform(new DOMSource(findChild(fault, null, "faultstring")), new StreamResult(writer));
} catch (TransformerException e) {
//The error message cannot be parsed... weird.
}
throw OlapExceptionHelper.createException(
"XMLA provider gave exception: " + message
+ "; request: " + request);
"XMLA provider gave exception: \n" + writer.getBuffer()
+ "\n Request was: \n" + request);
}
Element discoverResponse =
findChild(body, XMLA_NS, "DiscoverResponse");
Expand Down
2 changes: 1 addition & 1 deletion testsrc/org/olap4j/ConnectionTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ public void testInvalidStatement() throws SQLException {
switch (tester.getFlavor()) {
case XMLA:
assertTrue(e.getMessage().indexOf(
"XMLA provider gave exception: XMLA MDX parse failed") >= 0);
"XMLA MDX parse failed") >= 0);
break;
default:
assertTrue(
Expand Down

0 comments on commit 7f766f2

Please sign in to comment.