Skip to content

Commit

Permalink
MONDRIAN-1438. Disabled testDatabaseMetaDataGetMembers, which was fai…
Browse files Browse the repository at this point in the history
…ling due to member ordinal values varying. MEMBER_ORDINAL is deprecated and will always return 0 once MONDRIAN-1378 is picked up, at which point this test can be re-enabled.
  • Loading branch information
Matt Campbell committed Mar 1, 2013
1 parent 5f1afbb commit 59a4c89
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/org/olap4j/impl/Bug.java
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,14 @@ public abstract class Bug {
*/
public static final boolean BugOlap4j3126853Fixed = false;

/**
* Whether
* <a href="http://jira.pentaho.com/browse/MONDRIAN-1378">,
* "Deprecate MemberOrdinal Property"</a>
* has been completed.
*/
public static final boolean BugMondrian1378Fixed = false;

}

// End Bug.java
8 changes: 8 additions & 0 deletions testsrc/org/olap4j/MetadataTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/
package org.olap4j;

import org.olap4j.impl.Bug;
import org.olap4j.impl.Olap4jUtil;
import org.olap4j.metadata.*;
import org.olap4j.test.TestContext;
Expand Down Expand Up @@ -701,6 +702,13 @@ public void testDatabaseMetaDataGetMeasures() throws SQLException {
}

public void testDatabaseMetaDataGetMembers() throws SQLException {
if (!Bug.BugMondrian1378Fixed) {
// Member ordinal values can vary based on how the member
// was loaded. This test can be re-enabled when member
// ordinal has been removed.
return;
}

String s = checkResultSet(
olapDatabaseMetaData.getMembers(
catalogName, "FoodMart", "Sales", null, "[Gender].[Gender]",
Expand Down

0 comments on commit 59a4c89

Please sign in to comment.