Skip to content

Commit

Permalink
Fixed coding standard issue and removed some useless calls that were …
Browse files Browse the repository at this point in the history
…costly in calculations and returned values that were not used.

git-svn-id: https://olap4j.svn.sourceforge.net/svnroot/olap4j/trunk@239 c6a108a4-781c-0410-a6c6-c2d559e19af0
  • Loading branch information
lucboudreau committed May 13, 2009
1 parent aff327d commit 58f55e1
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/org/olap4j/driver/xmla/XmlaOlap4jConnection.java
Original file line number Diff line number Diff line change
Expand Up @@ -388,8 +388,8 @@ public String getCatalog() throws OlapException {
// was specified by the user.
List<Catalog> catalogs = this.getCatalogs();
if (catalogs.size() == 0) {
throw new OlapException("There is no catalog " +
"available to query against.");
throw new OlapException(
"There is no catalog available to query against.");
} else {
this.catalogName = catalogs.get(0).getName();
}
Expand Down Expand Up @@ -933,10 +933,6 @@ public void handle(
</row>
*/
final String dimensionUniqueName =
stringElement(row, "DIMENSION_UNIQUE_NAME");
final XmlaOlap4jDimension dimension =
context.olap4jCube.dimensionsByUname.get(dimensionUniqueName);
final String hierarchyName =
stringElement(row, "HIERARCHY_NAME");
final String hierarchyUniqueName =
Expand Down Expand Up @@ -1331,7 +1327,6 @@ public void handle(
Name Level - Store Manager Property</DESCRIPTION>
</row>
*/
String cubeName = stringElement(row, "CUBE_NAME");
String description = stringElement(row, "DESCRIPTION");
String uniqueName = stringElement(row, "DESCRIPTION");
String caption = stringElement(row, "PROPERTY_CAPTION");
Expand Down

0 comments on commit 58f55e1

Please sign in to comment.