feat(aws): new dynamodb_table_cross_account_access check
#3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3932 +/- ##
==========================================
+ Coverage 86.37% 86.40% +0.02%
==========================================
Files 748 749 +1
Lines 23333 23393 +60
==========================================
+ Hits 20155 20213 +58
- Misses 3178 3180 +2 ☔ View full report in Codecov by Sentry. |
sergargar
changed the title
dynamodb_table_cross_account_access check
jfagoagas
requested changes
May 7, 2024
There was a problem hiding this comment.
Super great work @sergargar 👏
I left a suggestion and I think some lines are duplicated in the tests, other than that the rest is 🔝
Comment on lines
+29
to
+49
| for statement in policy_statements: | ||
| if not cross_account_access: | ||
| if statement["Effect"] == "Allow": | ||
| if "AWS" in statement["Principal"]: | ||
| principals = statement["Principal"]["AWS"] | ||
| if not isinstance(principals, list): | ||
| principals = [principals] | ||
| else: | ||
| principals = [statement["Principal"]] | ||
| for aws_account in principals: | ||
| if ( | ||
| dynamodb_client.audited_account not in aws_account | ||
| or "*" == aws_account | ||
| ): | ||
| cross_account_access = True | ||
| # Check if the condition block is restrictive | ||
| conditions = statement.get("Condition", {}) | ||
| if is_condition_block_restrictive( | ||
| conditions, dynamodb_client.audited_account | ||
| ): | ||
| cross_account_access = False |
There was a problem hiding this comment.
Could you please move this to a function in a lib, I think the same always, we are creating this over and over again.
There was a problem hiding this comment.
That's right, I have created a task to create a function and using it in these checks!
...ces/dynamodb/dynamodb_table_cross_account_access/dynamodb_table_cross_account_access_test.py
Outdated
Show resolved
Hide resolved
...ces/dynamodb/dynamodb_table_cross_account_access/dynamodb_table_cross_account_access_test.py
Outdated
Show resolved
Hide resolved
...ces/dynamodb/dynamodb_table_cross_account_access/dynamodb_table_cross_account_access_test.py
Outdated
Show resolved
Hide resolved
...ces/dynamodb/dynamodb_table_cross_account_access/dynamodb_table_cross_account_access_test.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Pepe Fagoaga <[email protected]>
jfagoagas
approved these changes
May 7, 2024
pedrooot
pushed a commit
that referenced
this pull request
May 15, 2024
Co-authored-by: Pepe Fagoaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@jchrisfarris in #3867: On march 20th, AWS announced Amazon DynamoDB now supports resource-based policies. It would be good to have a Prowler check to look for DDB tables that have been shared to other accounts (note: it's not possible to share a table publicly, so this is good).
Therefore, adding the new check:
dynamodb_table_cross_account_accessLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.