.gitpod.Dockerfile: Auto-fetch Go and goyacc versions #14130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedawnallah
force-pushed
the
fetchGoVersionGitpodDockerFile
branch
from
88e7e64
to
06a5b8d
Compare
|
Just tried opening a workspace, and somehow the version installed is not the one in go.mod 🤨 
I didn't have time to investigate the reason yet, but this doesn't sound like the behavior you wanted, right? |
mohamedawnallah
force-pushed
the
fetchGoVersionGitpodDockerFile
branch
from
06a5b8d
to
74c4d95
Compare
|
Apologies, @ArthurSens! Upon debugging, I discovered a conflict with the
|
mohamedawnallah
force-pushed
the
fetchGoVersionGitpodDockerFile
branch
from
74c4d95
to
19eec46
Compare
In this commit we auto-fetch Go version from go.mod and goyacc version from Makefile in the Prometheus repo. Signed-off-by: Mohamed Awnallah <[email protected]>
mohamedawnallah
force-pushed
the
fetchGoVersionGitpodDockerFile
branch
from
19eec46
to
5be753f
Compare
ArthurSens
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14122
How could this be tested?
Open the
fetchGoVersionGitpodDockerFilebranch in my forked Prometheus repository:https://github.com/mohamedawnallah/prometheus/tree/fetchGoVersionGitpodDockerFile
Make sure you have Gitpod browser extension installed
Click on the "Open in Gitpod" button in the GitHub repo.
Verify that there are no package missing errors and that the build runs successfully, including the test cases (excluding the flaky ones).