Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exemplar.toString #671

Closed
wants to merge 2 commits into from
Closed

Conversation

anuraaga
Copy link

@anuraaga anuraaga commented Jul 6, 2021

Co-authored-by: Josh Seureth <[email protected]>
Signed-off-by: Anuraag Agrawal <[email protected]>
@fstab
Copy link
Member

fstab commented Jul 8, 2021

Thanks for the PR. It would be useful to produce the same format as TextFormat.writeOpenMetrics100(), so that the toString() representation doesn't differ from the OpenMetrics format. What do you think?

@anuraaga
Copy link
Author

anuraaga commented Jul 9, 2021

Thanks @fstab - I took a look in but it seems quite difficult since TextFormat has some fairly complicated private methods such as omWriteTimestamp. Not to mention that TextFormat is not in simpleclient. So it's an interesting idea but I think unless we were to move at least some TextFormat logic into simpleclient it doesn't seem practical, it's essentially a circular dependency. I suppose conceptually speaking, simpleclient is protocol-agnostic, so expecting toString to follow a protocol is probably not practical.

Signed-off-by: Anuraag Agrawal <[email protected]>
@anuraaga
Copy link
Author

Very old PR that I should probably close :D

@anuraaga anuraaga closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants