feat: Implement byte matching in TCP query responses #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the exporter only supports lines, which breaks byte-oriented protocols such as the PostgreSQL StartTLS handshake. We also give a working example for Postgres in the sample configuration. Signed-off-by: Stanislav Grozev <[email protected]>
tacho
force-pushed
the
fix-postgres-tls-probes
branch
from
21d61c5
to
ac9bb34
Compare
|
Is there any ETA for this PR merge? |
|
I was wondering the same - it's been two months without any reaction. Is this project dead, or abandoned? |
|
+1 on this PR, we have the same issue which will be fixed after the merge |
|
+1 on this PR too, would be nice to have this builtin |
|
+1 if we can use blackbox exporter also for postgres |
|
FYI, here's a demo code to get Postgres cert info via TrustManager when connecting to the server https://github.com/Raymondmax/PostgresCert/blob/main/main.java |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the exporter only supports lines, which breaks byte-oriented protocols such as the PostgreSQL StartTLS handshake.
We also give a working example for Postgres in the sample configuration.
Fixes: #801