Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove contour xDS server implementation #6568

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skriss
Copy link
Member

@skriss skriss commented Jul 19, 2024

No description provided.

@skriss skriss added this to the 1.31.0 milestone Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (8d46632) to head (70b2eff).

Files Patch % Lines
cmd/contour/serve.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6568      +/-   ##
==========================================
- Coverage   81.76%   81.43%   -0.33%     
==========================================
  Files         133      130       -3     
  Lines       15942    15731     -211     
==========================================
- Hits        13035    12811     -224     
- Misses       2614     2631      +17     
+ Partials      293      289       -4     
Files Coverage Δ
cmd/contour/servecontext.go 85.79% <ø> (-0.16%) ⬇️
internal/contourconfig/contourconfiguration.go 98.68% <ø> (-0.01%) ⬇️
internal/xds/v3/callbacks.go 100.00% <100.00%> (ø)
internal/xdscache/v3/cluster.go 100.00% <ø> (ø)
internal/xdscache/v3/endpointslicetranslator.go 72.34% <ø> (-6.79%) ⬇️
internal/xdscache/v3/endpointstranslator.go 86.17% <ø> (-2.18%) ⬇️
internal/xdscache/v3/listener.go 91.72% <ø> (-0.40%) ⬇️
internal/xdscache/v3/route.go 95.58% <ø> (-0.71%) ⬇️
internal/xdscache/v3/runtime.go 96.87% <ø> (-3.13%) ⬇️
internal/xdscache/v3/secret.go 71.42% <ø> (-9.53%) ⬇️
... and 2 more

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant