-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature invoke activity #73
Conversation
I'd like to see support added for invoking a flow as compared to an activity. That would be a general solution |
@balamg Now I have added support to invoke flogo-action (ex: flow) |
Maybe you should consider leaving this as invoke activity? @skothari-tibco is implementing an activity that can invoke actions (not just flows). This way you have a lot more flexibility. If someone wants to invoke a simple rest call, they don't have to setup an entire flow for that. I guess if you can invoke either activity or action in this implementation it is fine also. |
Thank you @fm-tibco for sharing your input. Seems my PR message is not conveying enough about rule service in detail. In fact, this PR supports any action (not just flow-action) as rule service, as mentioned below: "services": [ Coming back to what to consider here activity vs action OR both - my original plan was to have just activity. As per the @balamg view mentioned above, action (flow) adds more value to rules. Appreciate your further inputs. |
closing this PR as an improved version of this feature (invoke activity) is available in develop branch. |
This PR implements #69. It enhances rule action function to
service
. Aservice
is constructed from agofunction
/flogo activity
/flogo action
.When a rules fires, corresponding service input expressions would be resolved from tuple scope and then service gets executed (i.e underlying function/activity/action gets executed).
A service definition goes like this:
Invoking the service:
An example covering all varients of
service
is made available at - examples/flogo/invokeservice