WIP: adding OCI output mode as buildctl does #621
+77
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: h4l0gen <[email protected]>
h4l0gen
requested review from
jeremyrickard,
sozercan and
ashnamehrotra
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
==========================================
+ Coverage 32.51% 33.03% +0.52%
==========================================
Files 17 18 +1
Lines 1621 1553 -68
==========================================
- Hits 527 513 -14
+ Misses 1062 1007 -55
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
| if outputFormat == "docker" { | ||
| solveOpt.Exports = append(solveOpt.Exports, client.ExportEntry{ | ||
| Type: client.ExporterDocker, | ||
| Attrs: map[string]string{ |
There was a problem hiding this comment.
Once it is working for OCI output it would also be good to add an integration test for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request using active verbs such as Add, Remove, Replace ...
This PR has one little issue it is WIP. I am resolving it by discussion with the maintainers
Closes #604