Remove unnecessary buffer #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I spent some time to make sure that all the corner cases were covered also. At first I wasn't sure that match_len would be reset correctly if there was no match, but it is. |
|
I've pushed the update to crates.io with version 0.1.3 |
|
Thanks! I will try to push into native tokio, but it's likely to be rejected so its good we have it here |
|
Linked PR tokio-rs/tokio#6531, we will see if it gets accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to removed the partial buffer with a better matching algorithm.
I don't think I missed edge cases. Essentially it remembers the match position of the needle in-between loop runs so it restarts from that position in the needle.