Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Re open issue with config flag #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobiasKaminsky
Copy link

@tobiasKaminsky tobiasKaminsky commented May 24, 2019

Fix #204

It is my first time contributing here and I could not test it.
However I hope that this enhancement is straight forward and works as intended.


View rendered README.md

@tobiasKaminsky
Copy link
Author

Any feedback on this?
I would really love to have this in.

@tobiasKaminsky
Copy link
Author

Any feedback here?

@tobiasKaminsky
Copy link
Author

Rebased onto latest mastert

@hbokh
Copy link

hbokh commented Nov 12, 2019

Maybe ping @JasonEtco will help?

@JasonEtco
Copy link
Member

👋 I'm not sure I understand the goal here. When an issue is closed and you want to reopen it, couldn't you just reopen it? That will count as activity and prevent Stale from attempting to close it until its stale again, and is a much clearer signal that an issue needs to be talked about again.

@tobiasKaminsky
Copy link
Author

@JasonEtco thanks for reply.
In our repo only admins can re-open a ticket, but all user can comment on it.
And as we have many many issues, I tend to ignore closed tickets, especially since the stale bot.

@JasonEtco
Copy link
Member

Appreciate the clarification @tobiasKaminsky! In that case, either this bot would be blocked by the same restrictions, or this would be a mechanism for getting around a restriction explicitly set by repo admins. I'm not sure that that's a good idea, given that people usually enable those things for a reason.

Ignoring closed tickets is kind of the whole point of Stale - if you aren't going to act on it, close it to focus on the issues that you can act on - otherwise reopen them. Frankly, I'd look at lifting that restriction. Sorry if that isn't helpful, but it doesn't sound like a problem that Stale can really fix!

@tobiasKaminsky
Copy link
Author

tobiasKaminsky commented Nov 18, 2019

@JasonEtco thanks for keeping up this discussion.
So regarding "reopen tickets" I found: https://stackoverflow.com/a/21333938

`
If you are not a collaborator of a repo, then (in regards to issues)

you can open issues
you can comment on all existing issues (open or closed)
you can close your own issues
you can re-open your own issues *if you closed them yourself
you cannot close or re-open issues opened by someone else
you cannot re-open your own issues if a repo collaborator closed them

`

This means that if

  • user a creates an issue
  • stale bot closes it
  • user a cannot reopen it, as it was not closed by user a

So in my case, it goes even further:

  • user a replies and states that it is still an issue
  • I do only see it if I check all closed issues
  • I then manually reopen it
Stack Overflow
I have reported an issue to a project. Now owner changed it state to closed, but how can I change it to open again ? I read somewhere that I need rights for push and pull operation. Is that true ?

@tobiasKaminsky
Copy link
Author

Here is a real life example:
nextcloud/android#4667

It got closed by stale bot, which is totally fine.
Then someone replied and I ignored it was "just" a response to a closed ticket and from overview I could not see who replied last, if it is was stale-bot or an user.
So I stumbled across it by accident and now I have to manually re-open it.

@stale
Copy link

stale bot commented Feb 23, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Feb 23, 2020
@tobiasKaminsky
Copy link
Author

Is this still relevant?

Yes :-)

@stale stale bot removed the wontfix label Feb 24, 2020
@stale
Copy link

stale bot commented May 24, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label May 24, 2020
@stale stale bot removed the wontfix label May 27, 2020
@stale
Copy link

stale bot commented Aug 29, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Aug 29, 2020
@tobiasKaminsky
Copy link
Author

Still relevant, at least for me ;-)
As it is done via a config option, I would love to have this in :-)

@stale stale bot removed the wontfix label Aug 31, 2020
@mohan43u
Copy link

stale bot closed issues should be re-opened automatically once someone reply on closed issue.

@stale
Copy link

stale bot commented May 10, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label May 10, 2021
@williamdes
Copy link

stale bot closed issues should be re-opened automatically once someone reply on closed issue.

👍🏻 🤖

@stale stale bot removed the wontfix label May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reopen stale issue after reply
5 participants