Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to TypeScript v5.5 #83

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Aug 27, 2024

The first part that toward closing #81.

cc @privatenumber

With TypeScript 5.5, tsc --showConfig now returns extra fields (default settings).

Jest expect#toMatchObject only supports an object that has extra fields (large object) to match against an object that has fewer fields (small objects). So I swapped the order in failing test cases and changed toStrictEqual w/ toMatchObject. I also added TODO comments to track these temporary changes.

@SukkaW
Copy link
Contributor Author

SukkaW commented Aug 27, 2024

Note that there are still 2 failing tests:

image

With TypeScript 5.5, tsc --showConfig no longer resolves excludes to absolute paths, hence the failing test cases.

@SukkaW SukkaW marked this pull request as draft August 27, 2024 08:51
@privatenumber privatenumber marked this pull request as ready for review August 29, 2024 00:37
@privatenumber privatenumber changed the title test: TS 5.5 chore: upgrade to TypeScript v5.5 Aug 29, 2024
@privatenumber privatenumber merged commit f4ffc32 into privatenumber:master Aug 29, 2024
2 of 3 checks passed
@privatenumber
Copy link
Owner

Thanks @SukkaW !

@privatenumber
Copy link
Owner

🎉 This issue has been resolved in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants