feat: support TS5 extends array
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add tests? |
|
I added a test and upgraded TypeScript to 5.0 for testing. But it is causing a type error at the test because |
.vscode/settings.json
Outdated
| "typescript.tsdk": "node_modules/typescript/lib", | ||
| "editor.formatOnSave": false, | ||
| "editor.formatOnPaste": false |
There was a problem hiding this comment.
I eliminated this change from the commit tree.
| @@ -25,7 +25,7 @@ function resolveFromPackageJsonPath(packageJsonPath: string) { | |||
| ); | |||
| } | |||
|
|
|||
| export function resolveExtends( | |||
| export function resolveExtendsPath( | |||
There was a problem hiding this comment.
I changed it because its name conflicted with the new function created. I don't have any idea of new naming of the function. Can you help it?
Co-authored-by: hiroki osame <[email protected]>
shun-shobon
force-pushed
the
feature/support-multiple-extends
branch
from
63c77fd
to
5dfd2c0
Compare
|
Will release after sindresorhus/type-fest#580 |
|
OK. Thank you for reviewing and refactoring! |
privatenumber
changed the title
extendsextends array
|
馃帀 This PR is included in version 4.5.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports Multiple Configuration Files in
extends, supported in TS 5.0.types-festdoes not yet support multiple files, but I have created a PR and will soon. 馃槈fix #44