Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add malicious security support to oneshot bench #1405

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andyleiserson
Copy link
Collaborator

We no longer need to (try to) exercise the complete step space in collect_steps, so this also reduces the set of supported configs to (semi-honest, malicious) × (32 or 256 breakdowns), all with 3-bit trigger value and 3-bit saturating sum. (Timestamp and output value also remain fixed at BA20 and BA32, respectively.)

@andyleiserson
Copy link
Collaborator Author

@tyurek FYI since we were talking about profiling today: I use this for flamegraphs with cargo flamegraph --root --bench oneshot_ipa --features "enable-benches disable-metrics multi-threading" -- -n 100000 -j 8. Be aware, however, that the bottlenecks indicated by a CPU profile with in-memory networking can be quite different than the bottlenecks in a real cluster.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 29.68750% with 45 lines in your changes missing coverage. Please review.

Project coverage is 93.46%. Comparing base (52c58eb) to head (098a663).

Files with missing lines Patch % Lines
ipa-core/src/test_fixture/ipa.rs 29.68% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
- Coverage   93.49%   93.46%   -0.04%     
==========================================
  Files         223      223              
  Lines       38396    38434      +38     
==========================================
+ Hits        35900    35921      +21     
- Misses       2496     2513      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants