[DRAFT} Batch convert RP25519 to u64 #1393
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It results in 14% speed up for semi-honest implementation. I couldn't check malicious improvements yet because of issues inside ZKP, but it should benefit from this improvement as well
This is done purely for performance reasons. We only convert PRF_CHUNK points in a batch, which in current setting means 16. Instead of converting Ristretto point $P$, we convert $2 \times P$ which should yield 64 bit values of the same quality. Unfortunately, [double and compress](https://docs.rs/curve25519-dalek/latest/curve25519_dalek/ristretto/struct.RistrettoPoint.html#method.double_and_compress_batch) is quite clunky to use as it only takes an iterator over borrowed values, so more than 50% of this PR is basically my silly attempt to get around that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #1391 and local testing shows some significant improvements in latency. Will do some Draft runs before making it ready for review.