Revise comment about chunk override for attribution #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
=======================================
Coverage 93.55% 93.55%
=======================================
Files 222 222
Lines 36936 36936
=======================================
+ Hits 34554 34557 +3
+ Misses 2382 2379 -3 ☔ View full report in Codecov by Sentry. |
|
2M, 19:16: https://draft-mpc.vercel.app/query/view/plain-witch2024-10-25T2258 This is slower than the baseline in #1370, so I don't think we want to take the change, but I will revise the comment. |
andyleiserson
changed the title
akoshelev
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originally removed the chunk override for attribution, but that was observed to impact performance, so now is just revising the comment to accurately describe the situation.