Implement reveal for upgraded contexts only #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
- Coverage 92.25% 92.23% -0.03%
==========================================
Files 197 197
Lines 29825 29951 +126
==========================================
+ Hits 27514 27624 +110
- Misses 2311 2327 +16 ☔ View full report in Codecov by Sentry. |
akoshelev
approved these changes
Aug 1, 2024
| &rv_share | ||
| .reveal(ctx.narrow(&Step::RevealR), record_id) | ||
| .await?, | ||
| &malicious_reveal(ctx.narrow(&Step::RevealR), record_id, None, &rv_share) |
There was a problem hiding this comment.
it is maybe worth renaming this protocol to check_zero_malicious because it is no longer "default" implementation (can be made cheaper by using semi-honest reveal). We only use it in MAC-based validation, so it should be just a rename imo
| let mut rng = thread_rng(); | ||
| let mut config = TestWorldConfig::default(); | ||
| config.stream_interceptor = | ||
| MaliciousHelper::new(Role::H3, config.role_assignment(), interceptor::<Boolean>); |
There was a problem hiding this comment.
nice! it works for DZKP too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another piece of #1112. This modifies the reveal implementations so that reveal is implemented only for upgraded contexts, and not for any
C: Context. The danger ofimpl Reveal<C: Context> for /* semi honest */ AdditiveShare<F>is that it could accidentally be invoked by a protocol intending to have DZKP malicious security.This changes the
check_zeroprotocol used for MAC-based malicious security to use a malicious reveal, however, there is still a problem with the zero check, see #1204 (comment).The reveals in PRF evaluation are changed to call
malicious_revealdirectly because the PRF doesn't yet take a context of an appropriate type. I've added a TODO, which can be cleaned up with the changes for malicious security in the PRF.