-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onchain decider for Protogalaxy #172
Open
winderica
wants to merge
17
commits into
privacy-scaling-explorations:main
Choose a base branch
from
winderica:protogalaxy-decider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Onchain decider for Protogalaxy #172
winderica
wants to merge
17
commits into
privacy-scaling-explorations:main
from
winderica:protogalaxy-decider
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Together with the existing `MatrixGadget` and `VectorGadget`, we can now use the same logic for checking R1CS satisfiability of `R1CSVar` both natively and non-natively.
… folding commitments
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #145.
This PR implements the onchain decider for Protogalaxy, which follows the design of Nova's decider described in Sonobe docs.
Specifically, the prover generates a Groth16 proof for the decider circuit and a KZG proof for the commitment$\phi$ in Protogalaxy's committed instance.
sonobe/folding-schemes/src/folding/protogalaxy/decider_eth.rs
Lines 160 to 171 in 6a8ccad
In addition, the randomness (i.e., the evaluations of
sonobe/folding-schemes/src/folding/protogalaxy/decider_eth.rs
Line 153 in 6a8ccad
sonobe/folding-schemes/src/folding/protogalaxy/decider_eth.rs
Lines 173 to 178 in 6a8ccad
Later, the verifier uses the randomness to compute the group operations in NIFS.V, i.e., the random linear combination of commitments in the running and incoming instances.
sonobe/folding-schemes/src/folding/protogalaxy/decider_eth.rs
Lines 201 to 207 in 6a8ccad
With the folded commitment
U_final_commitments
as a public input, the verifier checks the validity of Groth16 proof. The KZG proof is also verified againstU_final_commitments
.sonobe/folding-schemes/src/folding/protogalaxy/decider_eth.rs
Lines 209 to 237 in 6a8ccad
Note that the decider circuit already enforces that the randomness indeed consists of the evaluations of$L_i(X)$ , so the prover cannot cheat by providing the verifier with incorrect randomness.