Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add prismaSchemaFolder support to prisma generate via mergeSchemas #24127

Merged
merged 10 commits into from May 10, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented May 8, 2024

This PR closes https://github.com/prisma/team-orm/issues/1043.
It likely works out of the box to Prisma Studio due to backward compatibility (to check later, once migrate is done), so this PR also contributes to https://github.com/prisma/team-orm/issues/1044.

@jkomyno jkomyno self-assigned this May 8, 2024
@jkomyno jkomyno added this to the 5.14.0 milestone May 8, 2024
@jkomyno jkomyno changed the title feat(cli): add prismaSchemaFolder support to prisma generate via mergeSchemas feat(cli): add prismaSchemaFolder support to prisma generate via mergeSchemas May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

size-limit report 📦

Path Size
packages/client/runtime/library.js 179.77 KB (0%)
packages/client/runtime/library.d.ts 81 B (0%)
packages/client/runtime/binary.js 600.89 KB (0%)
packages/client/runtime/binary.d.ts 26 B (0%)
packages/client/runtime/edge.js 159.02 KB (0%)
packages/client/runtime/edge-esm.js 158.91 KB (0%)
packages/client/runtime/wasm.js 114.85 KB (0%)
packages/client/runtime/index-browser.js 33.77 KB (0%)
packages/client/runtime/index-browser.d.ts 89 B (0%)
packages/cli/build/index.js 2.09 MB (+0.05% 🔺)
packages/client/prisma-client-0.0.0.tgz 3.02 MB (-0.01% 🔽)
packages/cli/prisma-0.0.0.tgz 3.74 MB (+0.01% 🔺)
packages/bundle-size/da-workers-libsql/output.tgz 888.14 KB (0%)
packages/bundle-size/da-workers-neon/output.tgz 966.74 KB (0%)
packages/bundle-size/da-workers-pg/output.tgz 985.47 KB (0%)
packages/bundle-size/da-workers-pg-worker/output.tgz 941.18 KB (0%)
packages/bundle-size/da-workers-planetscale/output.tgz 903.56 KB (0%)
packages/bundle-size/da-workers-d1/output.tgz 861.2 KB (0%)

Copy link
Contributor

@SevInf SevInf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks and questions, other than that - looks good. Once tests are green we can merge it, i think.

packages/client/src/generation/TSClient/TSClient.ts Outdated Show resolved Hide resolved
packages/internals/src/cli/getSchema.ts Show resolved Hide resolved
packages/internals/src/get-generators/getGenerators.ts Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #24127 will improve performances by 31.46%

Comparing feat/generate-prismaSchemaFolder (8032811) with main (23aba0b)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/generate-prismaSchemaFolder Change
client generation 100 models with relations 40.7 s 30.9 s +31.46%

@jkomyno jkomyno marked this pull request as ready for review May 10, 2024 14:56
@jkomyno jkomyno requested a review from a team as a code owner May 10, 2024 14:56
@jkomyno jkomyno requested review from Druue and removed request for a team May 10, 2024 14:56
@jkomyno jkomyno merged commit 6fcc818 into main May 10, 2024
214 checks passed
@jkomyno jkomyno deleted the feat/generate-prismaSchemaFolder branch May 10, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants