Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller auth0 package #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prestontighe
Copy link

@prestontighe prestontighe commented Nov 10, 2017

  • Remove isomorphic-fetch (not being used)

* Remove isomorphic-fetch (not being used)
@prestontighe prestontighe changed the title master Smaller auth0 package Nov 10, 2017
@timwis
Copy link

timwis commented Nov 15, 2017

I was under the impression isomorphic-fetch just attached itself to the window or global object, so that the fetch that's used later is defined.

@kbrandwijk
Copy link
Contributor

@timwis You are right, it is used indeed. It could have been node-fetch however, because it doesn't run in the browser anyways. I would also use import fetch from 'node-fetch' so it's clear that it is actually being used.

@prestontighe
Copy link
Author

prestontighe commented Nov 15, 2017

Ah ok didn't know what it did. Creating a global variable from requiring a package seems like bad practice to me but o well. At least do import fetch from 'node-fetch' like you said @kbrandwijk .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants